efi_loader: error handling for `efidebug boot add`

In  `efidebug boot add iPXE scsi 0:1 snp-arm64.efi --foo` a parameter is
missing. Hence the command should not silently return as if everything were
ok but should display the usage info.

Signed-off-by: Heinrich Schuchardt <[email protected]>
Reviewed-by: Alexander Graf <[email protected]>

diff --git a/cmd/efidebug.c b/cmd/efidebug.c
index 5072a7b39bc0cc620a21f6b9fd17a784ee88f8db..db96682c5a4ca9e0416643b83396aa88d13074a8 100644 (file)
--- a/cmd/efidebug.c
+++ b/cmd/efidebug.c
@@ -491,7 +491,7 @@ static int do_efi_boot_add(cmd_tbl_t *cmdtp, int flag,
 
        id = (int)simple_strtoul(argv[1], &endp, 16);
        if (*endp != '\0' || id > 0xffff)
-               return CMD_RET_FAILURE;
+               return CMD_RET_USAGE;
 
        sprintf(var_name, "Boot%04X", id);
        p = var_name16;